Skip to content

Fix: Allow --version option with workload restore#52048

Merged
marcpopMSFT merged 2 commits intorelease/10.0.3xxfrom
copilot/fix-workload-restore-issue
Jan 24, 2026
Merged

Fix: Allow --version option with workload restore#52048
marcpopMSFT merged 2 commits intorelease/10.0.3xxfrom
copilot/fix-workload-restore-issue

Conversation

Copy link
Contributor

Copilot AI commented Dec 5, 2025 •
edited
Loading

dotnet workload restore --version <version> fails with error "Cannot use the --skip-manifest-update and --sdk-version options together" even though these options should be compatible for restore operations.

Root Cause

workload restore internally calls WorkloadInstallCommand with skipManifestUpdate: true to avoid duplicate manifest updates. The validation logic rejected this combination without accounting for the restore context where users legitimately specify --version while the implementation uses skipManifestUpdate.

Changes

  • WorkloadInstallCommand.cs: Added !IsRunningRestore guard to version/skip-manifest validation (line 158), matching the existing pattern for global.json validation (line 165)
  • GivenDotnetWorkloadRestore.cs: Added test verifying --version no longer triggers the conflict error

Example

# Previously failed with validation error
dotnet workload restore --version 9.0.100

# Now proceeds to install specified workload version
Original prompt

This section details on the original issue you should resolve

<issue_title>Can't Restore Workloads with Version</issue_title>
<issue_description>### Describe the bug
dotnet workload restore --version breaks if you give it a version (e.g. 9.0.305) or as the --help text suggests, a workload and a version (e.g. ios@9.0.305).

To Reproduce

  1. mkdir test
  2. cd test
  3. dotnet new console
  4. dotnet workload restore --version 9.0.305

Exceptions (if any)

dotnet exits with code 1 and this message:

Cannot use the --skip-manifest-update and --sdk-version options together.  Remove one of the options.

Further technical details

details of dotnet --info

.NET SDK: Version: 9.0.305 Commit: 3fc74f3 Workload version: 9.0.305 MSBuild version: 17.14.21+8929ca9e3

Runtime Environment:
OS Name: Windows
OS Version: 10.0.19045
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\9.0.305\

.NET workloads installed:
[android]
Installation Source: SDK 9.0.300, VS 17.14.36310.24
Manifest Version: 35.0.101/9.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\9.0.100\microsoft.net.sdk.android\35.0.101\WorkloadManifest.json
Install Type: Msi

[ios]
Installation Source: SDK 9.0.300, VS 17.14.36310.24
Manifest Version: 18.5.9219/9.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\9.0.100\microsoft.net.sdk.ios\18.5.9219\WorkloadManifest.json
Install Type: Msi

[maccatalyst]
Installation Source: SDK 9.0.300, VS 17.14.36310.24
Manifest Version: 18.5.9219/9.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\9.0.100\microsoft.net.sdk.maccatalyst\18.5.9219\WorkloadManifest.json
Install Type: Msi

[maui-windows]
Installation Source: SDK 9.0.300, VS 17.14.36310.24
Manifest Version: 9.0.82/9.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\9.0.100\microsoft.net.sdk.maui\9.0.82\WorkloadManifest.json
Install Type: Msi

Configured to use workload sets when installing new manifests.

Host:
Version: 9.0.9
Architecture: x64
Commit: 893c2ebbd4

.NET SDKs installed:
2.1.526 [C:\Program Files\dotnet\sdk]
5.0.300 [C:\Program Files\dotnet\sdk]
6.0.101 [C:\Program Files\dotnet\sdk]
6.0.201 [C:\Program Files\dotnet\sdk]
7.0.410 [C:\Program Files\dotnet\sdk]
8.0.413 [C:\Program Files\dotnet\sdk]
9.0.302 [C:\Program Files\dotnet\sdk]
9.0.305 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.All 2.1.24 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.25 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.27 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.28 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.24 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.25 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.27 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.28 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.32 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.17 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.36 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.18 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.19 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.24 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.25 [C:\Program Files\dotnet\shared\Microsoft.NETC...

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix workload restore failure with specific version input Fix: Allow --version option with workload restore Dec 6, 2025
Copilot AI requested a review from marcpopMSFT December 6, 2025 00:23
This was referenced Dec 6, 2025
Open
Open
@marcpopMSFT marcpopMSFT marked this pull request as ready for review December 10, 2025 01:18
@marcpopMSFT
Copy link
Member

marcpopMSFT commented Dec 10, 2025

Tested in codespaces. Was able to specify different versions when running restore and confirmed it restored the right versions.

@marcpopMSFT marcpopMSFT requested a review from nagilson December 10, 2025 01:19
@marcpopMSFT marcpopMSFT force-pushed the copilot/fix-workload-restore-issue branch from 7c66320 to a4cb144 Compare December 13, 2025 00:12
@build-analysis build-analysis bot mentioned this pull request Dec 13, 2025
Closed
Copilot AI and others added 2 commits December 15, 2025 15:39
@marcpopMSFT
Fix workload restore --version conflict with skip-manifest-update
26be18a 
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
@marcpopMSFT
Fix code formatting issues
eaf204d 
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
@marcpopMSFT marcpopMSFT force-pushed the copilot/fix-workload-restore-issue branch from a4cb144 to eaf204d Compare December 15, 2025 23:39
@marcpopMSFT marcpopMSFT changed the base branch from release/10.0.2xx to release/10.0.3xx January 16, 2026 18:31
@mmitche mmitche deleted the branch release/10.0.3xx January 17, 2026 00:40
@mmitche mmitche closed this Jan 17, 2026
@marcpopMSFT marcpopMSFT reopened this Jan 20, 2026
nagilson
nagilson approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, under the assumption IsRunningRestore is correct.

@marcpopMSFT marcpopMSFT merged commit f11caaa into release/10.0.3xx Jan 24, 2026
28 checks passed
@marcpopMSFT marcpopMSFT deleted the copilot/fix-workload-restore-issue branch January 24, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagilson nagilson nagilson approved these changes

+1 more reviewer

@marcpopMSFT marcpopMSFT marcpopMSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marcpopMSFT marcpopMSFT

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcpopMSFT @nagilson @mmitche